Skip to content

fix issue with invalid macro name if used as a component #7500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

supcik
Copy link
Contributor

@supcik supcik commented Nov 20, 2022

Description of Change

This change fixes the ADRDUION_<BOARD>_DEV macro name defined by CMakeList.txt.

Tests scenarios

I used it successfully on a project with a ttgo-lora-v1.

Related links

Closes issue #7499

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @supcik !

@SuGlider SuGlider self-assigned this Dec 9, 2022
@me-no-dev me-no-dev merged commit 744cbc2 into espressif:master Dec 13, 2022
@supcik supcik deleted the issue-7499 branch December 13, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Invalid macro name if Arduino is used as a component in esp-idf and the board name contains a dash
5 participants